Fix a failing test case intermittenly in TestMergeOnRead due to incorrect prev commit time #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect prev commit time
|
@vinothchandar pinging to re-surface |
|
Will add a test case soon to concretely add this case : #450 |
bvaradar
reviewed
Sep 7, 2018
| @@ -235,7 +235,6 @@ public WriteStatus close() { | |||
| if (writer != null) { | |||
| writer.close(); | |||
| } | |||
| writeStatus.getStat().setPrevCommit(commitTime); | |||
There was a problem hiding this comment.
@n3nash : Can you provide some context here around this and why this needs to be removed?
There was a problem hiding this comment.
@bvaradar Yes, so essentially 2 reasons :
- For inserts we always have PREV_COMMIT set to NULL as you can see in HoodieCreateHandle, I want to keep the same semantics
- Say a log file was created with commit = 101. Now, when an update comes along for this log file at commit = 102, the write status will be set PREV_COMMIT = 102. Now, any rollback will try to write to a log file with commit = 102 which is incorrect. This got introduced in the inserts to log files diff.
bvaradar
approved these changes
Sep 7, 2018
| @@ -235,7 +235,6 @@ public WriteStatus close() { | |||
| if (writer != null) { | |||
| writer.close(); | |||
| } | |||
| writeStatus.getStat().setPrevCommit(commitTime); | |||
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vinothchandar This should fix the failing test case in dependency removal.