Fix bug with incrementally pulling older data #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3nash
reviewed
Sep 16, 2018
| @@ -88,8 +88,12 @@ class IncrementalRelation(val sqlContext: SQLContext, | |||
| .get, classOf[HoodieCommitMetadata]) | |||
| fileIdToFullPath ++= metadata.getFileIdAndFullPaths(basePath).toMap | |||
| } | |||
| // unset the path filter, otherwise if end_instant_time < latest_instant_time, path filter | |||
There was a problem hiding this comment.
Can you describe this a little more please ? By reading offhand, this is not clear.
There was a problem hiding this comment.
Missing context is in how the RO view is implemented. It sets a path filter to filter all files except latest.. if we don't unset here, filter still kicks in and filters out all files when dealing with older instant ranges
bvaradar
approved these changes
Sep 17, 2018
| @@ -98,14 +98,24 @@ class DataSourceTest extends AssertionsForJUnit { | |||
|
|
|||
|
|
|||
| // Read Incremental View | |||
| val firstCommit = HoodieDataSourceHelpers.listCommitsSince(fs, basePath, "000").get(0); | |||
There was a problem hiding this comment.
Add a description here for the newly added test-case ?
vinothchandar
force-pushed
the
datasource
branch
from
ff5cbc9 to
1e8cee7
Compare
vinothchandar
commented
Sep 17, 2018
| @@ -88,8 +88,12 @@ class IncrementalRelation(val sqlContext: SQLContext, | |||
| .get, classOf[HoodieCommitMetadata]) | |||
| fileIdToFullPath ++= metadata.getFileIdAndFullPaths(basePath).toMap | |||
| } | |||
| // unset the path filter, otherwise if end_instant_time is not the latest instant, path filter set for RO view | |||
There was a problem hiding this comment.
@n3nash updated comments.
vinothchandar
commented
Sep 17, 2018
| @@ -98,14 +98,26 @@ class DataSourceTest extends AssertionsForJUnit { | |||
|
|
|||
|
|
|||
| // Read Incremental View | |||
| // we have 2 commits, try pulling the first commit (which is not the latest) | |||
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.