Add --filter-dupes to DeltaStreamer #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vinothchandar
commented
Oct 3, 2018
vinothchandar
commented
- Optionally filter out duplicates before inserting data
- Unit tests
- Optionally filter out duplicates before inserting data - Unit tests
vinothchandar
commented
Oct 3, 2018
| @@ -142,4 +143,19 @@ public static HoodieRecord createHoodieRecord(GenericRecord gr, Comparable order | |||
| HoodieRecordPayload payload = DataSourceUtils.createPayload(payloadClass, gr, orderingVal); | |||
| return new HoodieRecord<>(hKey, payload); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
@leletan I reused your method here.. if I land first, then you can just add a new overload that takes parameters and call this..
There was a problem hiding this comment.
@vinothchandar Ack. Thanks for letting me know
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.