Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Follow up HUDI-27 : Call super.close() in HoodieWraperFileSystem::close() #621

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

vinothchandar
Copy link
Member

  • FileSystem.close() does clean up of cache etc.

@n3nash
Copy link
Contributor

n3nash commented Apr 1, 2019

Can you please share you understanding of super.close() in this context ? So, super is basically the current instance of FileSystem being extended by the current instance of HoodieWrapperFileSystem. The HoodieWrapperFileSystem also holds an instance of the underlying file system as a member variable. What wil super.close() behavior be here once it is invoked ?

@vinothchandar
Copy link
Member Author

Well super.close() is pretty obvious. Its the FIleSystem class's close(), which does some clean up of the cache etc. @bvaradar pointed out that it might be good to clean it up for the HoodieWrapperFileSystem instance..

I still think closing the wrapped file system, is not a good idea, since its cached globally across jvm.

@n3nash
Copy link
Contributor

n3nash commented Apr 2, 2019

Okay, fair enough.

@n3nash n3nash self-requested a review April 2, 2019 23:34
@vinothchandar vinothchandar merged commit 51f4908 into apache:master Apr 3, 2019
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Apr 9, 2024
Co-authored-by: Jonathan Vexler <=>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants