Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HUDI-101: added mevn-shade plugin with filters. #659

Merged
merged 1 commit into from
May 3, 2019
Merged

HUDI-101: added mevn-shade plugin with filters. #659

merged 1 commit into from
May 3, 2019

Conversation

abhioncbr
Copy link

For HUDI-101: maven shade plugin added with exclusions filter. Please review.

Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhioncbr for the contribution. Can you manually verify and confirm if *SF and other related files are not present in any of the below jars
hoodie-hadoop-mr-bundle
hoodie-spark-bundle
hoodie-presto-bundle
hoodie-hive-bundle
hoodie-utilities

@abhioncbr
Copy link
Author

Sure. I am going to comment after checking all the jars.

@abhioncbr
Copy link
Author

Just checked, jars have no such file in META-INF folder.

Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhioncbr . Looks good to me.

Just to be safe, can you run 2 things

  1. mvn integration-test
  2. Run demo locally as described : http://hudi.incubator.apache.org/docker_demo.html

I will merge the change as soon as you can test and confirm if everything works fine.

Balaji.V

@abhioncbr
Copy link
Author

option "--schemaprovider-class com.uber.hoodie.utilities.schema.FilebasedSchemaProvider" is required for deltastreamer jobs.

@bvaradar
Copy link
Contributor

bvaradar commented May 3, 2019

Per @abhioncbr , all the steps in the demo are working.

@bvaradar bvaradar merged commit f47f0eb into apache:master May 3, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants