Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "HUDI-101: added mevn-shade plugin with filters." #665

Merged
merged 1 commit into from
May 6, 2019

Conversation

bvaradar
Copy link
Contributor

@bvaradar bvaradar commented May 6, 2019

The original PR is accidentally creating fat jars for all hoodie packages ( including hoodie-common, hoodie-client,....)

This reverts commit f47f0eb.

Creates fat jars for all hoodie packages

This reverts commit f47f0eb.
@bvaradar bvaradar requested review from vinothchandar and n3nash May 6, 2019 01:32
@bvaradar
Copy link
Contributor Author

bvaradar commented May 6, 2019

@abhioncbr : While investigating another issue, I realized even hoodie-common has become a fat jar. You might need to move your base pom file change to each bundle's pom file or do other maven tricks (if at all there is) to avoid fat jars for all packages.

@bvaradar
Copy link
Contributor Author

bvaradar commented May 6, 2019

Merging this change myself to keep master sane

@bvaradar bvaradar merged commit ee1feb7 into apache:master May 6, 2019
@abhioncbr
Copy link

@bvaradar I will try to look if shade plugin can be applicable on selective sub-projects or using some else plugin which can help us to achieve the intent. Can you please list down the sub-projects for which fat jar is not needed?

@abhioncbr
Copy link

Just checked, all four bundle packages pom in packaging folder & hoodie-utilities pom already using maven-shade-plugin. I think it's better to move exclusion entries there. @bvaradar, please share your input.

@bvaradar
Copy link
Contributor Author

bvaradar commented May 6, 2019

@abhioncbr : Yes, that seems fine

vinishjail97 pushed a commit to vinishjail97/hudi that referenced this pull request May 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants