[HUDI-6092] Reuse schema objects while deserializing log blocks. #8484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Apr 18, 2023
|
|
||
| return new CloseableMappingIterator<>(recordIterator, data -> (HoodieRecord<T>) data); | ||
| return new CloseableMappingIterator<>(recordIterator, data -> (HoodieRecord<T>) data); | ||
| } |
There was a problem hiding this comment.
Is the iterator still valid when the outer reader has been closed ?
There was a problem hiding this comment.
Probably not. I will backup these changes which introduce try block.
I think the intention is to return an iterator which will close the reader after iteration (hence the name ClosableIterator).
danny0405
added
code-refactor
writer-core
prashantwason
force-pushed
the
pw_reuse_schema_objects
branch
from
952ed0d to
04ccb55
Compare
|
@hudi-bot run azure |
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[HUDI-6092] Reuse schema objects while deserializing log blocks.
Change Logs
Also introduced some try { } blocks in code to auto close resources which were being leaked.
Impact
When reading log files with a very large number of log blocks, there is reduced memory consumption.
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist