Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(catalog/glue): add support for list namespaces #169

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat(catalog/glue): add support for list namespaces #169

merged 1 commit into from
Oct 15, 2024

Conversation

natusioe
Copy link
Contributor

Add support for ListNamespaces to the Glue catalog.

Implementation Details

  • Similar to tables, used the same ICEBERG parameter to differentiate between Iceberg catalog databases and other databases in the Glue catalog.
  • Throw an error when parent parameter is given to ListNamespaces to align with Python implementation.

Testing Done

  • Tests are added similar to others in the test file.
  • Set up AWS Glue Catalog in my personal account and created a database and verified that it can be fetched.

zeroshade
zeroshade approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, just the one question

@nastra nastra merged commit 00d758f into apache:main Oct 15, 2024
13 checks passed
@natusioe natusioe mentioned this pull request Oct 16, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

@nastra nastra nastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natusioe @nastra @zeroshade