feat(table/scanner): Implement Arrow type promotion and conversion #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
force-pushed
the
scanner-from-conversion
branch
from
d4e08d6 to
5b4cda9
Compare
nastra
approved these changes
Oct 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #168 which should get merged first.
Adds proper handling for ensuring small or large types for Arrow data along with implementing a function to convert/cast record batch columns to appropriate and uniform iceberg types based on the iceberg schema itself. Also implements an
ExtractFieldIDsmethod for extracting the field ids that are necessary for a given filter expression.