Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(catalog): Send X-Iceberg-Access-Delegation header to signal support for vended credentials #67

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Feb 16, 2024

Clients can optionally send this header to signal which delegated access pattern it can support. At this point the iceberg-go client can only support vended-credentials out-of-the-box, thus we can always send this header.
Addtional details about this header can be found in the REST OpenAPI spec: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L1459-L1483

…ort for vended credentials

Clients can optionally send this header to signal which delegated access
pattern it can support. At this point the iceberg-go client can only
support `vended-credentials` out-of-the-box, thus we can always send
this header.
Addtional details about this header can be found in the REST OpenAPI
spec: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L1459-L1483
@nastra nastra force-pushed the send-access-delegation-header branch from 5b71492 to b85b941 Compare February 16, 2024 10:05
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@Fokko Fokko merged commit 5db83a0 into apache:main Feb 16, 2024
5 checks passed
@nastra nastra deleted the send-access-delegation-header branch February 16, 2024 16:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants