-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement Debug
trait for public structs
#73
Labels
good first issue
Good for newcomers
Comments
zeodtr
changed the title
Implement Debug trait for public structs
Implement Oct 4, 2023
Debug
trait for public structs
+1 for this proposal. |
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 4, 2023
DeaconDesperado
added a commit
to DeaconDesperado/iceberg-rust
that referenced
this issue
Nov 8, 2023
Fokko
pushed a commit
that referenced
this issue
Nov 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
It's useful to implement
Debug
trait for public structs.The Rust document strongly recommends it: https://doc.rust-lang.org/std/fmt/index.html#fmtdisplay-vs-fmtdebug
Also, I found that there is a lint directive for it: https://doc.rust-lang.org/stable/nightly-rustc/rustc_lint/builtin/static.MISSING_DEBUG_IMPLEMENTATIONS.html
Maybe it would be nice to include that lint directive as
deny
tolib.rs
.Also, can traits like
Catalog
be modified to be dependent uponDebug
trait like this?It would be convenient when including a
Box dyn
edtrait
member to astruct
that wants to implementDebug
trait. Otherwise, sinceDebug
trait is not an auto trait, we must create a new wrapper trait only to specifyDebug
trait dependency.Also, (maybe this is somewhat irrelevant to this issue. If so, ignore this) it would be convenient if
Catalog
trait be modified to be dependent also uponSend
andSync
like this:Since
Catalog
trait is an async trait, addingSend
andSync
can be useful. (BTW, I've added them to a trait that wraps theCatalog
trait to includeDebug
trait.)Thanks.
The text was updated successfully, but these errors were encountered: