Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Add integration tests for rest catalog. #109

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

liurenjie1024
Copy link
Collaborator

Close #100 .

@liurenjie1024
Copy link
Collaborator Author

cc @Fokko @Xuanwo @ZENOTME @JanKaul PTAL

Makefile Outdated Show resolved Hide resolved
crates/catalog/rest/Cargo.toml Outdated Show resolved Hide resolved
@liurenjie1024 liurenjie1024 force-pushed the renjie/issue-100 branch 2 times, most recently from 4b919a4 to 53df4cb Compare December 4, 2023 07:19
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @liurenjie1024 ! Thanks for adding this, appreciate it!

Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM. Thanks!

crates/catalog/rest/src/catalog.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@liurenjie1024
Copy link
Collaborator Author

cc @Fokko I've resolved conflicts.

@Fokko Fokko merged commit 641d058 into apache:main Dec 8, 2023
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Rest catalog integration test.
5 participants