Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add hms catalog layout #112

Merged
merged 3 commits into from
Dec 7, 2023
Merged

feat: Add hms catalog layout #112

merged 3 commits into from
Dec 7, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 4, 2023

This PR is a basic layout for hms support.

This PR solely implements list_namespaces, allowing us to concentrate on crucial matters such as general API style and creating room for future implementation.


TODO

There is a plan for hive_metastore to migrate to volo for better hive metastore client that don't need thrift, async support and so on. But it requires rust nightly (rust 1.75).

We should not be blocked by Xuanwo/hive_metastore_rs#2. Let's move on and migrate after rust 1.75 released.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 4, 2023

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request Dec 6, 2023
2 tasks
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good! I'm thinking to add a HMS to the CI for the Python part, might also be interesting for Rust to run integration tests against.

@Fokko Fokko merged commit eb33e90 into apache:main Dec 7, 2023
6 checks passed
@Xuanwo Xuanwo deleted the hms-catalog branch December 7, 2023 11:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants