Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Use macro to define from error. #17

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: Use macro to define from error. #17

merged 2 commits into from
Aug 3, 2023

Conversation

liurenjie1024
Copy link
Collaborator

Use macro rules to generate from error code, so that we don't need to repeat for every kind of error.

Xuanwo
Xuanwo approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

JanKaul
JanKaul approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@JanKaul JanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@liurenjie1024
Copy link
Collaborator Author

cc @Fokko @nastra PTAL

@Fokko Fokko merged commit aa53409 into apache:main Aug 3, 2023
7 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/add-macro-error branch August 3, 2023 06:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JanKaul JanKaul JanKaul approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@Fokko Fokko Fokko approved these changes

@nastra nastra Awaiting requested review from nastra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liurenjie1024 @Fokko @Xuanwo @JanKaul