Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add utility methods to help conversion between literals. #38

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

liurenjie1024
Copy link
Collaborator

Close #33 .

Thanks for @Fokko 's suggestion. Add them so that we can make literals more convenient.

crates/iceberg/src/spec/values.rs Outdated Show resolved Hide resolved
crates/iceberg/src/spec/values.rs Outdated Show resolved Hide resolved
crates/iceberg/src/spec/values.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Collaborator

@JanKaul JanKaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@liurenjie1024
Copy link
Collaborator Author

CC @Fokko PTAL

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @liurenjie1024 Looking good!

@Fokko Fokko merged commit d6963cf into apache:main Aug 28, 2023
7 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-33 branch August 28, 2023 11:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow conversion between literal values
4 participants