Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Make directory for catalog #69

Merged
merged 1 commit into from
Sep 27, 2023
Merged

refactor: Make directory for catalog #69

merged 1 commit into from
Sep 27, 2023

Conversation

liurenjie1024
Copy link
Collaborator

With more catalogs coming, we should make catalog module a directory rather a file.

@liurenjie1024
Copy link
Collaborator Author

cc @Xuanwo @Fokko @JanKaul @ZENOTME PTAL

Fokko
Fokko approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

Xuanwo
Xuanwo approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Fokko Fokko merged commit a7f0434 into apache:main Sep 27, 2023
6 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/catalog-refactor branch September 27, 2023 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@Fokko Fokko Fokko approved these changes

@JanKaul JanKaul Awaiting requested review from JanKaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liurenjie1024 @Fokko @Xuanwo