Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Migrate from tempdir to tempfile crate #91

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

cdaudt
Copy link
Contributor

@cdaudt cdaudt commented Nov 3, 2023

tempdir is obsolete and relies on remove_dir_all 0.5.3 which has a security vulnerability. Migrate to using tempfile crate instead. References:

Copy link
Collaborator

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @cdaudt, and thanks for fixing this. Can you resolve the conflicts?

tempdir is obsolete and relies on remove_dir_all 0.5.3 which has a
security vulnerability. Migrate to using tempfile crate instead.
References:
- [RUSTSEC-2018-0017](https://rustsec.org/advisories/RUSTSEC-2018-0017)
- [RUSTSEC-2013-0018](https://rustsec.org/advisories/RUSTSEC-2023-0018)
@cdaudt
Copy link
Contributor Author

cdaudt commented Nov 13, 2023

Great catch @cdaudt, and thanks for fixing this. Can you resolve the conflicts?

done

@liurenjie1024
Copy link
Collaborator

CC @Fokko

@Fokko Fokko merged commit 3b5c35e into apache:main Nov 15, 2023
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Nov 15, 2023

Thanks @cdaudt for fixing this, and @liurenjie1024 & @Xuanwo for the review 🙌

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants