feat(server): improve logging for deserializing invalid server command

apache · Feb 17, 2025 · 794a6d5 · 794a6d5
1 parent 7a9bbde
commit 794a6d5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/server/Cargo.toml b/server/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "server"
-version = "0.4.205"
+version = "0.4.206"
 edition = "2021"
 build = "src/build.rs"
 license = "Apache-2.0"

diff --git a/server/src/command.rs b/server/src/command.rs
@@ -51,6 +51,7 @@ use iggy::{
 };
 use std::fmt::{Display, Formatter};
 use strum::EnumString;
+use tracing::error;
 
 #[derive(Debug, PartialEq, EnumString)]
 pub enum ServerCommand {
@@ -263,7 +264,10 @@ impl BytesSerializable for ServerCommand {
             GET_SNAPSHOT_FILE_CODE => Ok(ServerCommand::GetSnapshotFile(GetSnapshot::from_bytes(
                 payload,
             )?)),
-            _ => Err(IggyError::InvalidCommand),
+            _ => {
+                error!("Invalid server command: {:?}", code);
+                Err(IggyError::InvalidCommand)
+            }
         }
     }
 }

diff --git a/server/src/tcp/connection_handler.rs b/server/src/tcp/connection_handler.rs
@@ -46,7 +46,6 @@ pub(crate) async fn handle_connection(
         sender.read(&mut command_buffer).await?;
         let command = ServerCommand::from_bytes(command_buffer.freeze());
         if command.is_err() {
-            error!("Received an invalid TCP command.");
             sender
                 .send_error_response(IggyError::InvalidCommand)
                 .await?;