Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(gitextractor): update database store, set it incremental by default #7660

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix(gitextractor): update database store, set it incremental by default #7660

merged 3 commits into from
Jun 25, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Jun 25, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Fix a typo
  2. Set database store used in gitextractor incremental according to GitcliCloner's status, to avoid the unexpected deletetions when gitexctractor collecting data incrementally.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins labels Jun 25, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@d4x1 d4x1 merged commit 12164c1 into main Jun 25, 2024
11 checks passed
@d4x1 d4x1 deleted the dev0625 branch June 25, 2024 06:12
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
@d4x1
fix(gitextractor): update database store, set it incremental by defau…
c64d34d 
…lt (#7660)

* fix(gitextractor): update database store, set it incremental by default

* fix(gitextractor): add `SetIncrementalMode` to store

* style(gitextractor): fix ci errors
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 25, 2024
d4x1 added a commit that referenced this pull request Jun 25, 2024
@github-actions @d4x1
fix(gitextractor): update database store, set it incremental by defau…
6aa0a7e 
…lt (#7660) (#7661)

* fix(gitextractor): update database store, set it incremental by default

* fix(gitextractor): add `SetIncrementalMode` to store

* style(gitextractor): fix ci errors

Co-authored-by: Lynwee <linwei.hou@merico.dev>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @klesh