[NEMO-364] Upgrade Beam version #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wynot12
reviewed
Mar 20, 2019
wynot12
requested changes
Mar 20, 2019
examples/beam/src/main/java/org/apache/nemo/examples/beam/GenericSourceSink.java
Outdated
Show resolved
Hide resolved
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This was a patch for the bug on the Beam side, but it's been resolved after the 2.10.0 update. Here's the link: https://beam.apache.org/blog/2019/02/15/beam-2.10.0.html
Please refer to the line that says: SQL: JDBC driver no longer breaks interactions with other JDBC sources
| @@ -247,7 +247,6 @@ public void saveOptimizationMetricsToDB(final String address, final String id, f | |||
|
|
|||
| try (final Connection c = DriverManager.getConnection(address, id, passwd)) { | |||
| LOG.info("Opened database successfully at {}", MetricUtils.POSTGRESQL_METADATA_DB_NAME); | |||
| MetricUtils.deregisterBeamDriver(); | |||
wynot12
approved these changes
Mar 20, 2019
|
Great! I'm good to merge it :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-364: Upgrade Beam
Major changes:
Minor changes to note:
Tests for the changes:
Other comments:
Closes #204