Skip to content

Website header add ASF menu #388

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wuchunfu
Copy link
Member

Website header add ASF menu

@ghost
Copy link

ghost commented Mar 16, 2024

CI report:

Bot commands @xtable-bot supports the following commands:
  • @xtable-bot run azure re-run the last Azure build

@wuchunfu
Copy link
Member Author

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am building the site locally but I don't see the new menu. Can you please share the steps that you did to test this change?

@wuchunfu
Copy link
Member Author

I am building the site locally but I don't see the new menu. Can you please share the steps that you did to test this change?

@zabetak Thank you for your review. The red box represents the effect of the modifications I made this time
image

@wuchunfu wuchunfu requested a review from zabetak March 20, 2024 10:53
@zabetak
Copy link
Member

zabetak commented Mar 20, 2024

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

@wuchunfu
Copy link
Member Author

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

@zabetak Oh, it's my fault. When I run the npm run start command, it can appear, but now the organization of this document doesn't seem to be a standard docusaurus. The index page now looks like a fixed index.html file. Normal docusaurus can be generated automatically. Do you need to adjust it to standard docusaurus?

@zabetak
Copy link
Member

zabetak commented Mar 21, 2024

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

@wuchunfu
Copy link
Member Author

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

Yes, I will finish this work later, but this method is a bit troublesome. Actually, the top menu docusaurus will be automatically generated, and I plan to optimize this content later

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants