Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modify module names in pom.xml to reflect the apache compliant names in NOTICE file #511

Closed
wants to merge 1 commit into from

Conversation

vinishjail97
Copy link
Contributor

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

#509
Addressing the feedback provided by @zabetak in rc3, modifying the module name in pom.xml, which generates a NOTICE file like this.

Apache XTable (incubating) Core
Copyright 2024 The Apache Software Foundation


This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).

Brief change log

(for example:)

  • Modify module names in pom.xml to reflect the apache compliant names in NOTICE file

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change the module names for fixing the NOTICE files. Let me raise a PR with an alternative more focused fix.

@zabetak
Copy link
Member

zabetak commented Aug 13, 2024

@vinishjail97 Please check #512 and let me know what you think.

@vinishjail97
Copy link
Contributor Author

Closing this as there's a better approach to solve this -> #512

@vinishjail97 vinishjail97 deleted the 509-License branch August 13, 2024 15:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants