Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set keep_files as false in GH action for site deploy to remove lingering pages #535

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

vinishjail97
Copy link
Contributor

@vinishjail97 vinishjail97 commented Sep 11, 2024

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

The previous PR removed the downloads page from the website and worked locally but GH action had this config as true so downloads page wasn't removed completely from http and was lingering around.

https://xtable.apache.org/releases/downloads/
https://github.com/peaceiris/actions-gh-pages?tab=readme-ov-file#%EF%B8%8F-keeping-existing-files-keep_files

Brief change log

(for example:)

  • Fix GH action to remove pages

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

@vinishjail97 vinishjail97 changed the title Set keep_files as false in GH action for site deploy Set keep_files as false in GH action for site deploy to remove lingering pages Sep 11, 2024
@jcamachor jcamachor merged commit 493e187 into main Sep 11, 2024
2 checks passed
@jcamachor jcamachor deleted the RemovePages branch September 11, 2024 18:09
@vinishjail97 vinishjail97 mentioned this pull request Oct 3, 2024
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants