Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[564] mirror parent dependency scopes in child pom files #563

Merged
merged 1 commit into from
Oct 6, 2024
Merged

[564] mirror parent dependency scopes in child pom files #563

merged 1 commit into from
Oct 6, 2024

Conversation

the-other-tim-brown
Copy link
Contributor

@the-other-tim-brown the-other-tim-brown commented Oct 5, 2024 •
edited
Loading

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

Addresses #564
Helps avoid confusion around a dependency's scope when working within or inspecting a module

Brief change log

  • Define the scope of any dependency that is not simply compile in our child poms

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

@the-other-tim-brown the-other-tim-brown changed the title mirror parent dependency scopes in child pom files [564] mirror parent dependency scopes in child pom files Oct 5, 2024
@the-other-tim-brown the-other-tim-brown merged commit 6816a83 into apache:main Oct 6, 2024
4 checks passed
@the-other-tim-brown the-other-tim-brown deleted the add-scopes branch October 6, 2024 18:42
@vinishjail97 vinishjail97 mentioned this pull request Oct 31, 2024
Closed
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vinishjail97 vinishjail97 vinishjail97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-other-tim-brown @vinishjail97