Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[To dev/1.3] Add logs for PartitionTableAutoCleaner #14948

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

CRZbulabula
Copy link
Contributor

Since the log for the PartitionTableAutoCleaner is insufficient, this PR replenish the following logs:

  1. The clean cycle is recorded when the PartitionTableAutoCleaner is constructed.
  2. The deleted time partitions of each database are recorded.

* Finished

* optimize autoCleanPartitionTable

* Update SeriesPartitionTable.java

---------

Co-authored-by: Potato <tanxinyu@apache.org>
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 41.36%. Comparing base (ff64e9e) to head (5cc5ce8).
Report is 5 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
.../iotdb/commons/partition/SeriesPartitionTable.java 0.00% 11 Missing ⚠️
.../persistence/partition/DatabasePartitionTable.java 0.00% 9 Missing ⚠️
...he/iotdb/commons/partition/DataPartitionTable.java 0.00% 4 Missing ⚠️
...onfignode/persistence/partition/PartitionInfo.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #14948      +/-   ##
=============================================
- Coverage      41.38%   41.36%   -0.03%     
  Complexity       193      193              
=============================================
  Files           3535     3535              
  Lines         226286   226285       -1     
  Branches       26895    26894       -1     
=============================================
- Hits           93656    93604      -52     
- Misses        132630   132681      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OneSizeFitsQuorum
Copy link
Contributor

Please see the failed test

@CRZbulabula CRZbulabula force-pushed the cp-partition-cleaner-log branch from 5cc5ce8 to ff22312 Compare February 26, 2025 14:14
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit f64dcd1 into dev/1.3 Feb 26, 2025
51 of 53 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the cp-partition-cleaner-log branch February 26, 2025 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants