Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE-5877] Fix SessionDataSet not close automatically #6134

Conversation

wallezhang
Copy link
Contributor


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write

Close #5877


Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@wallezhang wallezhang changed the title [IOTDB-5877] Fix SessionDataSet not close automatically [ISSUE-5877] Fix SessionDataSet not close automatically Jun 1, 2022
Copy link
Member

@qiaojialin qiaojialin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@qiaojialin qiaojialin merged commit 964f321 into apache:master Jun 1, 2022
@wallezhang wallezhang deleted the fix-SessionDataSet-not-close-automatically branch June 1, 2022 15:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use try-with-resources or close this "SessionDataSet" in a "finally" clause.
2 participants