Skip to content

Commit

Permalink
MINOR: Fix Benchmark sys tests (#18796)
Browse files Browse the repository at this point in the history
This patch fixes the Benchmark system tests. We misconfigured the quorum in bc7b870.

```
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id:       2025-02-04--001
run time:         57 minutes 27.169 seconds
tests run:        62
passed:           62
flaky:            0
failed:           0
ignored:          0
================================================================================
```

Reviewers: PoAn Yang <payang@apache.org>, Christo Lolov <lolovc@amazon.com>
  • Loading branch information
dajac authored Feb 4, 2025
1 parent f6d9ce2 commit 17d1447
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions tests/kafkatest/benchmarks/core/benchmark_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ def start_kafka(self, security_protocol, interbroker_security_protocol, version,
@parametrize(acks=1, topic=TOPIC_REP_THREE, metadata_quorum=quorum.isolated_kraft)
@parametrize(acks=-1, topic=TOPIC_REP_THREE, metadata_quorum=quorum.isolated_kraft)
@matrix(acks=[1], topic=[TOPIC_REP_THREE], message_size=[10, 100, 1000, 10000, 100000],
compression_type=["none", "snappy"], security_protocol=['SSL'], tls_version=['TLSv1.2', 'TLSv1.3'], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], security_protocol=['SSL'], tls_version=['TLSv1.2', 'TLSv1.3'], metadata_quorum=[quorum.isolated_kraft])
@matrix(acks=[1], topic=[TOPIC_REP_THREE], message_size=[10, 100, 1000, 10000, 100000],
compression_type=["none", "snappy"], security_protocol=['PLAINTEXT'], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], security_protocol=['PLAINTEXT'], metadata_quorum=[quorum.isolated_kraft])
@parametrize(acks=1, topic=TOPIC_REP_THREE, num_producers=3, metadata_quorum=quorum.isolated_kraft)
def test_producer_throughput(self, acks, topic, num_producers=1, message_size=DEFAULT_RECORD_SIZE,
compression_type="none", security_protocol='PLAINTEXT', tls_version=None, client_version=str(DEV_BRANCH),
Expand Down Expand Up @@ -97,8 +97,8 @@ def test_producer_throughput(self, acks, topic, num_producers=1, message_size=DE

@cluster(num_nodes=7)
@matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'],
compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
def test_long_term_producer_throughput(self, compression_type="none",
security_protocol='PLAINTEXT', tls_version=None,
interbroker_security_protocol=None, client_version=str(DEV_BRANCH),
Expand Down Expand Up @@ -155,9 +155,9 @@ def test_long_term_producer_throughput(self, compression_type="none",

@cluster(num_nodes=8)
@matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'],
compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
@matrix(security_protocol=['SASL_PLAINTEXT', 'SASL_SSL'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
@matrix(security_protocol=['SASL_PLAINTEXT', 'SASL_SSL'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
def test_end_to_end_latency(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None,
interbroker_security_protocol=None, client_version=str(DEV_BRANCH),
broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft):
Expand Down Expand Up @@ -187,8 +187,8 @@ def test_end_to_end_latency(self, compression_type="none", security_protocol="PL

@cluster(num_nodes=8)
@matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'],
compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
def test_producer_and_consumer(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None,
interbroker_security_protocol=None,
client_version=str(DEV_BRANCH), broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft):
Expand Down Expand Up @@ -235,8 +235,8 @@ def test_producer_and_consumer(self, compression_type="none", security_protocol=

@cluster(num_nodes=8)
@matrix(security_protocol=['SSL'], interbroker_security_protocol=['PLAINTEXT'], tls_version=['TLSv1.2', 'TLSv1.3'],
compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=quorum.isolated_kraft)
compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
@matrix(security_protocol=['PLAINTEXT'], compression_type=["none", "snappy"], metadata_quorum=[quorum.isolated_kraft])
def test_consumer_throughput(self, compression_type="none", security_protocol="PLAINTEXT", tls_version=None,
interbroker_security_protocol=None, num_consumers=1,
client_version=str(DEV_BRANCH), broker_version=str(DEV_BRANCH), metadata_quorum=quorum.isolated_kraft):
Expand Down

0 comments on commit 17d1447

Please # to comment.