Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join #18813

Merged
merged 3 commits into from
Feb 8, 2025
Merged

MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join #18813

merged 3 commits into from
Feb 8, 2025

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Feb 6, 2025

No description provided.

bbejeck
bbejeck approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mjsax - a couple of minor comments for your consideration, LGTM

streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java Outdated
* {@link ValueJoinerWithKey}, one output for each input {@code KStream} record
* @see #join(KTable, ValueJoinerWithKey)
* @see #leftJoin(GlobalKTable, KeyValueMapper, ValueJoinerWithKey)
* <p>Note that the key is read-only and must not be modified, as this can lead to corrupt partitioning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding which would lead to unexpected results or something similar?

streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java Outdated
* {@link ValueJoinerWithKey}, one output for each input {@code KStream} record
* @see #join(KTable, ValueJoinerWithKey, Joined)
* @see #leftJoin(GlobalKTable, KeyValueMapper, ValueJoinerWithKey)
* <p>Note that the key is read-only and must not be modified, as this can lead to corrupt partitioning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@mjsax mjsax force-pushed the minor-update-kstreams-javadocs-10 branch from 974f8ab to cb975bb Compare February 7, 2025 22:46
@mjsax
Copy link
Member Author

mjsax commented Feb 8, 2025

Java 17:

Found 2 flaky test failures:
FLAKY ⚠️  CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment()
FLAKY ⚠️  KRaftClusterTest > testDescribeQuorumRequestToControllers()

Java 23:

Found 3 flaky test failures:
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceived()
FLAKY ⚠️  FeatureCommandTest > testUpgradeWithReleaseVersion [1] Type=Raft-Isolated, MetadataVersion=3.8-IV0,BrokerSecurityProtocol=PLAINTEXT,BrokerListenerName=ListenerName(EXTERNAL),ControllerSecurityProtocol=PLAINTEXT,ControllerListenerName=ListenerName(CONTROLLER)
FLAKY ⚠️  KRaftClusterTest > testDescribeQuorumRequestToControllers()

@mjsax mjsax merged commit 8b22f10 into apache:trunk Feb 8, 2025
7 of 9 checks passed
@mjsax mjsax deleted the minor-update-kstreams-javadocs-10 branch February 8, 2025 01:58
pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
@mjsax @pdruley
MINOR: cleanup KStream JavaDocs (10/N) - stream-table-left-join (apac…
0b6a737 
…he#18813)

Reviewers: Bill Bejeck <bill@confluent.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
docs streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjsax @bbejeck