New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Release session if shared level is CONNECTION #381

Closed

ulysses-you opened this issue Mar 1, 2021 · 0 comments

Contributor

ulysses-you commented Mar 1, 2021 •

edited

Loading

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Add a config to keep the legacy behavior.

Describe alternatives you've considered
In CONNECTION level, it's better to release session if the connection is closed.

Additional context

ulysses-you added a commit that referenced this issue


          [KYUUBI #381] Release session if shared level is CONNECTION

7f2a24b

![ulysses-you](https://badgen.net/badge/Hello/ulysses-you/green) [![Closes #382](https://badgen.net/badge/Preview/Closes%20%23382/blue)](https://github.com/yaooqinn/kyuubi/pull/382) ![85](https://badgen.net/badge/%2B/85/red) ![1](https://badgen.net/badge/-/1/green) ![20](https://badgen.net/badge/commits/20/yellow) ![Test Plan](https://badgen.net/badge/Missing/Test%20Plan/ff0000) [&#10088;?&#10089;](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
In CONNECTION level, it's better to release session if the connection is closed.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

Closes #382 from ulysses-you/KYUUBI-381.

cddba6c [ulysses-you] type
a3fd691 [ulysses-you] increase engine init timeout
5030553 [ulysses-you] reload system properties
7a2e72f [ulysses-you] clean code
1034409 [ulysses-you] stopped
d2a001a [ulysses-you] address comment
4eb62de [ulysses-you] 60s
64d0f16 [ulysses-you] fix test
4f10d34 [ulysses-you] sleep
62dc9f9 [ulysses-you] add new stop method
77be261 [ulysses-you] remove config
fd9b73c [ulysses-you] add time sleep
209a59e [ulysses-you] fix test
88ed744 [ulysses-you] import
90015e9 [ulysses-you] simply
311fce3 [ulysses-you] fix test
7af3f72 [ulysses-you] fix test
e91377c [ulysses-you] Merge branch 'master' of https://github.com/yaooqinn/kyuubi into KYUUBI-381
f77ddbe [ulysses-you] nit
2173222 [ulysses-you] init

Authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>

ulysses-you closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment