Exclude log4j12 from hive engine module classpath #6859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6859 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42463 42463
Branches 5796 5796
======================================
Misses 42463 42463 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Dec 25, 2024
turboFei
approved these changes
Dec 25, 2024
pan3793
added a commit
that referenced
this pull request
Dec 25, 2024
### Why are the changes needed? Kyuubi uses log4j2 as the logging framework, while I found that the Hive SQL engine module still polls log4j 1.2 to the classpath unexpectedly, we should exclude it to avoid potential issues. ``` build/mvn dependency:tree -pl :kyuubi-hive-sql-engine_2.12 ``` ``` ... [INFO] +- org.apache.hive:hive-service:jar:3.1.3:provided [INFO] | +- org.apache.hive:hive-exec:jar:3.1.3:provided [INFO] | | +- org.apache.zookeeper:zookeeper:jar:3.4.6:provided [INFO] | | | +- log4j:log4j:jar:1.2.16:provided ... ``` ### How was this patch tested? Checks `build/mvn dependency:tree | grep 'log4j:log4j:jar:1.2'` returns nothing and pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6859 from pan3793/exclude-log4j1. Closes #6859 287cf78 [Cheng Pan] Exclude log4j12 from hive engine module classpath Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit f844afa) Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
added a commit
that referenced
this pull request
Dec 25, 2024
### Why are the changes needed? Kyuubi uses log4j2 as the logging framework, while I found that the Hive SQL engine module still polls log4j 1.2 to the classpath unexpectedly, we should exclude it to avoid potential issues. ``` build/mvn dependency:tree -pl :kyuubi-hive-sql-engine_2.12 ``` ``` ... [INFO] +- org.apache.hive:hive-service:jar:3.1.3:provided [INFO] | +- org.apache.hive:hive-exec:jar:3.1.3:provided [INFO] | | +- org.apache.zookeeper:zookeeper:jar:3.4.6:provided [INFO] | | | +- log4j:log4j:jar:1.2.16:provided ... ``` ### How was this patch tested? Checks `build/mvn dependency:tree | grep 'log4j:log4j:jar:1.2'` returns nothing and pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6859 from pan3793/exclude-log4j1. Closes #6859 287cf78 [Cheng Pan] Exclude log4j12 from hive engine module classpath Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit f844afa) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.10.2/1.9.4 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Kyuubi uses log4j2 as the logging framework, while I found that the Hive SQL engine module still polls log4j 1.2 to the classpath unexpectedly, we should exclude it to avoid potential issues.
How was this patch tested?
Checks
build/mvn dependency:tree | grep 'log4j:log4j:jar:1.2'returns nothing and pass GHA.Was this patch authored or co-authored using generative AI tooling?
No.