SOLR-8573: Implement ConnectionImpl,StatementImpl,ResultSetImpl clear… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Warnings and getWarnings
Merged
dsmiley
referenced
this pull request
in dsmiley/lucene-solr
Sep 3, 2016
desultir
added a commit
to desultir/lucene-solr
that referenced
this pull request
Sep 6, 2016
Pull updates from SOLR head
asfgit
pushed a commit
that referenced
this pull request
Sep 5, 2017
LUCENE-7940: minor bengali fixes
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2019
… SimClusterStateProvider/SimCloudManager There are 3 tightly related bug fixes in these changes: 1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed to use synchronizedList wrappers. 2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape would timeout regardless of how long they waited.) To protect against "silent" failures like this, this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors will be logged and "counted." SimSolrCloudTestCase will ensure a suite level failure if any such failures are counted. 3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election: These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of replicas when the Callables were created vs when they were later run -- notably a Callable may have been created that held a reference to a Slice, but by the time that Callable was run the collection (or a node, etc...) refered to by that Slice may have been deleted. While fixing this, the leader election logic was also cleaned up such that adding a replica only triggers leader election for that shard, not every shard in the collection. While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was also cleaned up to remove all risky points where an exception may have been possible after aquiring the lock but before the try/finally that ensured it would be unlocked.
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2019
… SimClusterStateProvider/SimCloudManager There are 3 tightly related bug fixes in these changes: 1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed to use synchronizedList wrappers. 2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape would timeout regardless of how long they waited.) To protect against "silent" failures like this, this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors will be logged and "counted." SimSolrCloudTestCase will ensure a suite level failure if any such failures are counted. 3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election: These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of replicas when the Callables were created vs when they were later run -- notably a Callable may have been created that held a reference to a Slice, but by the time that Callable was run the collection (or a node, etc...) refered to by that Slice may have been deleted. While fixing this, the leader election logic was also cleaned up such that adding a replica only triggers leader election for that shard, not every shard in the collection. While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was also cleaned up to remove all risky points where an exception may have been possible after aquiring the lock but before the try/finally that ensured it would be unlocked. (cherry picked from commit 76babf8)
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2019
… SimClusterStateProvider/SimCloudManager There are 3 tightly related bug fixes in these changes: 1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed to use synchronizedList wrappers. 2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape would timeout regardless of how long they waited.) To protect against "silent" failures like this, this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors will be logged and "counted." SimSolrCloudTestCase will ensure a suite level failure if any such failures are counted. 3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election: These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of replicas when the Callables were created vs when they were later run -- notably a Callable may have been created that held a reference to a Slice, but by the time that Callable was run the collection (or a node, etc...) refered to by that Slice may have been deleted. While fixing this, the leader election logic was also cleaned up such that adding a replica only triggers leader election for that shard, not every shard in the collection. While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was also cleaned up to remove all risky points where an exception may have been possible after aquiring the lock but before the try/finally that ensured it would be unlocked. (cherry picked from commit 76babf8)
asfgit
pushed a commit
that referenced
this pull request
Mar 19, 2019
… SimClusterStateProvider/SimCloudManager There are 3 tightly related bug fixes in these changes: 1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed to use synchronizedList wrappers. 2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape would timeout regardless of how long they waited.) To protect against "silent" failures like this, this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors will be logged and "counted." SimSolrCloudTestCase will ensure a suite level failure if any such failures are counted. 3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election: These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of replicas when the Callables were created vs when they were later run -- notably a Callable may have been created that held a reference to a Slice, but by the time that Callable was run the collection (or a node, etc...) refered to by that Slice may have been deleted. While fixing this, the leader election logic was also cleaned up such that adding a replica only triggers leader election for that shard, not every shard in the collection. While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was also cleaned up to remove all risky points where an exception may have been possible after aquiring the lock but before the try/finally that ensured it would be unlocked.
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2019
msokolov
pushed a commit
to msokolov/lucene-solr
that referenced
this pull request
Dec 22, 2019
Implemented TestKnnGraph unit tests
markrmiller
added a commit
that referenced
this pull request
Jul 9, 2020
…r small collections API improvements and fixes.
markrmiller
added a commit
that referenced
this pull request
Jul 9, 2020
…lated cleanups and a couple other test fail fixes.
msokolov
pushed a commit
to msokolov/lucene-solr
that referenced
this pull request
Mar 17, 2021
LUCENE-9375: check github actions (merge PR).
bszabo97
pushed a commit
to bszabo97/lucene-solr
that referenced
this pull request
Mar 18, 2021
* Basic cleanup of README * Remove lucene DOAP file * Change gradle rootProject.name to solr-root * Remove badge and some more Lucene mentions. Added a link to Lucene webpage.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Warnings and getWarnings