Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MASSEMBLY-1004] Remove ignored and deprecated parameter - useJvmChmod #163

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MASSEMBLY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it appear in the docs somehwere?

@slawekjaranowski
Copy link
Member Author

Does it appear in the docs somehwere?

No. It is only old not used parameter.

@michael-o
Copy link
Member

Does it appear in the docs somehwere?

No. It is only old not used parameter.

Accepted.

@slawekjaranowski slawekjaranowski merged commit e2af63a into master Nov 8, 2023
37 checks passed
@slawekjaranowski slawekjaranowski deleted the MASSEMBLY-1004 branch November 8, 2023 21:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants