[DOXIASITETOOLS-109] handle more URI formats #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Feb 19, 2020
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java
Show resolved
Hide resolved
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/DefaultSiteToolTest.java
Show resolved
Hide resolved
elharo
commented
Mar 2, 2020
|
Nothing from the top of my head. I need to think about it a couple of days. Just go ahead and merge. If I can make up something I will open another JIRA issue. |
michael-o
approved these changes
Mar 2, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hboutemy Truly this method needs to be burned to the ground but for the moment, this PR recognizes a number of cases we don't correctly handle now and returns the default
toURL instead of the mangling the current code does with those.