[MGPG-135] Support Overriding / Enhance the signer in AbstractGpgMojo #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently AbstractGpgMojo has a fixed set of supported signers (and how they are constructed), it would be good to allow extensions (e.g. Tycho is also using AbstractGpgMojo) to possibly override that aspect.
This extracts the creation of the signer into a (protected) method so different types or alternative implementations can be used.
Following this checklist to help us incorporate your contribution quickly and easily:
before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should
address just this issue, without pulling in other changes.
[MGPG-XXX] - Fixes bug in ApproximateQuantiles
, where you replaceMGPG-XXX
with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the
first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check will be performed on your pullrequest automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure please ask on the
developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
the Apache License Version 2.0, January 2004
an Apache Individual Contributor License Agreement.