[MGPG-136] Windows passphrase corruption #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is shot in a dark, but should make possible to at least eliminate (if not even figure out) the issue on Windows with passphrase. --- https://issues.apache.org/jira/browse/MGPG-136
michael-o
requested changes
Sep 23, 2024
michael-o
requested changes
Sep 24, 2024
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
Sep 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.2.0 version we always appended "line separator" to passphrase unless it itself ended with one. But, this caused problem on Windows, as (our assumption is) that GPG uses binary read of STDIN, and on Windows "line separator" is "\r\n", while GPG handles "\n" only, making passphrase corrupted by presence of unwanted "\r".
https://issues.apache.org/jira/browse/MGPG-136