-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[MINSTALL-164] - Create GitHub Actions #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls merge
Pls pls merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why it is useful in comparison of the official build env but why not ...
@aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions:
All in all, is great help for reviewers but also for PR submitter.... (all this IF action covers ITs etc... as many maven projects does not run ITs in GH action yet, about to clean up) |
@cstamas done. Do we want to update the JDKs? |
And I see it is another way for GA ... here be using build in containers ... |
Cool, thanks! @slawekjaranowski @bmarwell am fine, I really just wanted to have ITs run here as well. |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MINSTALL-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MINSTALL-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.