Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MJAR-289] add toolchains support #71

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[MJAR-289] add toolchains support #71

wants to merge 1 commit into from

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Feb 27, 2024

https://issues.apache.org/jira/browse/MJAR-289

still need to test (I did not check on a project that uses toolchains) and create IT

@hboutemy hboutemy marked this pull request as draft February 27, 2024 23:31
@slawekjaranowski
Copy link
Member

Similar task was done in codehaus-plexus/plexus-compiler#357
Maybe we can extract code to some of commons library

@hboutemy
Copy link
Member Author

hboutemy commented Mar 1, 2024

any idea where you'd put that, so it has a chance to be reused? I fear it is overkill given the size of the feature

and the real value we need is the integration in the jar creation process and testing it in different cases: with or without toolchain, perhaps other scenario that we'll add in the future if we find some shortcomings

@slawekjaranowski
Copy link
Member

I think that it not resolve MJAR-289, it resolve only one case described in MJAR-62
For MJAR-289 we need a changes in plexus-archiver

So I have created #73 based on it

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants