Properly close DirectoryStream (#41)

Fixes MJAVADOC-644
apache · Mar 19, 2020 · 48c8420 · 48c8420
1 parent cb7ae05
commit 48c8420
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java b/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java
@@ -22,6 +22,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
@@ -139,10 +140,10 @@ public static void writeStaleData( Commandline cmd, Path path )
 
     private static Collection<Path> walk( Path dir )
     {
-        try
+        Collection<Path> paths = new ArrayList<>();
+        try ( DirectoryStream<Path> directoryStream = Files.newDirectoryStream( dir ) )
         {
-            Collection<Path> paths = new ArrayList<>();
-            for ( Path p : Files.newDirectoryStream( dir ) )
+            for ( Path p : directoryStream )
             {
                 paths.add( p );
             }