-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[MJAVADOC-538] Filter out 'Picked up' #11
Conversation
FWIW, I can confirm this solves the problem in my project. Thanks! |
edd1c8c
to
b0bee92
Compare
Added integration test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small things to improve, almost there.
b0bee92
to
3738762
Compare
@rfscholte Addressed your review comments. Thanks! |
One final request: add yourself as contributor to the root |
Signed-off-by: Kevin Risden <krisden@apache.org>
3738762
to
c05e8dc
Compare
@rfscholte added myself as contributor. Let me know if there is anything else :) |
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-javadoc-plugin/job/MJAVADOC-538/ |
Tested with:
mvn -Prun-its verify
Additional testing on project I was having original issues
mvn install
export JAVA_TOOL_OPTIONS="-Dapple.awt.UIElement=true"
mvn -Dmaven.javadoc.failOnError=true -Dmaven.javadoc.failOnWarnings=true javadoc:javadoc javadoc:test-javadoc
Prior to this change was getting failure from warning "Picked up ...". With this change, Javadoc no longer fails due to warning.