Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals. #2

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

busbey
Copy link
Contributor

@busbey busbey commented Mar 1, 2018

Follows the same pattern as JavadocNoForkReport with the aggregate goals.

Tested out locally by installing a SNAPSHOT version and then moving my project over to it.

@abudaev
Copy link

abudaev commented Mar 22, 2018

Can you release with goal ASAP?)

@busbey
Copy link
Contributor Author

busbey commented Mar 22, 2018

@abudaev this change hasn't been merged into the project source yet, so it's unlikely to be in a release in the short term.

For more info, esp to watch for updates, I'd recommend subscribing to MJAVADOC-444 on the project JIRA.

@abudaev
Copy link

abudaev commented Mar 22, 2018

@busbey maybe you know how to fix this trouble without your PR ->

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single (create distr) on project aggragator-module: Failed to create assembly: Error adding file 'javadoc-aggragate:module1:jar:1.0-SNAPSHOT' to archive: \trouble\module1\target\classes isn't a file. -> [Help 1]

example project structure
https://github.com/abudaev/trouble
mvn verify -P parrent-module

I think that it happened on maven life cycle miracles: fork, phases and etc. I'am trying many methods: different phases on assembly and javadoc plugins, set properties on aggregator project like this <maven.javadoc.skip>true<maven.javadoc.skip>. No works. I'm ready to cry

@busbey
Copy link
Contributor Author

busbey commented Mar 22, 2018

Hi @abudaev!

Your best bet is to bring the issue up on the users@maven mailing list or open a new issue with the details.

@khmarbaise
Copy link
Member

khmarbaise commented Mar 22, 2018

@busbey Hi, can you please remove the @version $Id$ entries from your changes...

@khmarbaise
Copy link
Member

So now I try to see what our CI says...

@khmarbaise
Copy link
Member

So unfortunately the CI build has failed please take a detail look here: https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-javadoc-plugin/job/MJAVADOC-444/1/console

@jdileonardo
Copy link

@khmarbaise @busbey

I just rebased this change locally to master it and it built successfully.

mvn clean verify failed the first time, similar to the error you posted @khmarbaise , but a second rebuild went through fine.

I think there's something behind the scenes with artifact resolution issues going on. I've seen this non-deterministic behavior lately while using mvn.

@rfscholte rfscholte merged commit 16aeaaf into apache:master Jan 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants