Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MJAVADOC-664] - Fix stale javadoc data detection on Windows. #63

Merged
merged 1 commit into from
Feb 27, 2021
Merged

[MJAVADOC-664] - Fix stale javadoc data detection on Windows. #63

merged 1 commit into from
Feb 27, 2021

Conversation

Syquel
Copy link
Contributor

@Syquel Syquel commented Oct 2, 2020

Replaces the usage of the full commandline by only its arguments to generate the stale javadoc detection key.
This approach allows to handle file-arguments appropriately in case of double-quoting by resolving them to their actual arguments.

@michaelboyles
Copy link
Contributor

Not a committer, but I think this unlikely to be accepted without a test

@slachiewicz
Copy link
Member

How I can test that functionality?

@Syquel
Copy link
Contributor Author

Syquel commented Feb 24, 2021

@slachiewicz I documented that mostly in MJAVADOC-664.
Do you need anything else?

Writing a unit test for this fix would require some time, which I am currently not able to invest, because there is no unit test for the feature itself yet.

//EDIT
For reference: #33 introduced this feature.

@slachiewicz slachiewicz merged commit 08510c2 into apache:master Feb 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants