Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JXR-176] Remove dependency org.apache.commons:commons-lang3 #76

Merged
merged 1 commit into from
Oct 16, 2022
Merged

[JXR-176] Remove dependency org.apache.commons:commons-lang3 #76

merged 1 commit into from
Oct 16, 2022

Conversation

spannm
Copy link
Contributor

@spannm spannm commented Aug 31, 2022

The project depended on commons-lang3 for its StringUtils.replace method only, which is a null-safe alternative to String.replace.
Review of StringUtils usage shows that affected variables cannot be null. Thus the dependency can be replaced by core Java.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [JXR-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace JXR-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@spannm
Copy link
Contributor Author

spannm commented Oct 14, 2022

Hi @slawekjaranowski hope you are doing great. Could you look at my PR and hopefully merge?

@slawekjaranowski
Copy link
Member

Please resolve conflicts.
For such PR jira issue will be appreciated.

The project depended on commons-lang3 for its StringUtils.replace method only,
which is a null-safe alternative to String.replace.
Review of StringUtils usage shows that affected variables cannot be null. Thus the dependency can be replaced by core Java.
@spannm spannm changed the title Remove dependency org.apache.commons:commons-lang3 [JXR-176] Remove dependency org.apache.commons:commons-lang3 Oct 16, 2022
@spannm
Copy link
Contributor Author

spannm commented Oct 16, 2022

Hi @slawekjaranowski,
Thanks again for your feedback.
Pull request rebased to master, merge conflicts resolved, issue JXR-176 created. Please re-review.
cheers,
Markus

@slawekjaranowski slawekjaranowski merged commit 6e00987 into apache:master Oct 16, 2022
@spannm spannm deleted the sman-81-jxr-commons-lang3 branch October 18, 2022 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants