Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[MSHADE-447] Do not use forked guice, use sisu from parent #188

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[MSHADE-447] Do not use forked guice, use sisu from parent #188

merged 2 commits into from
Jun 13, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 13, 2023 •
edited
Loading

Use proper Guice, same as Maven. Drop sisu plugin, is defined in parent.

https://issues.apache.org/jira/browse/MSHADE-447

@cstamas
Do not use forked guice
0ca38ad 
Use proper Guice, same as Maven
@cstamas cstamas self-assigned this Jun 13, 2023
@cstamas cstamas changed the title Do not use forked guice Do not use forked guice, use sisu from parent Jun 13, 2023
@cstamas cstamas changed the title Do not use forked guice, use sisu from parent [MSHADE-447] Do not use forked guice, use sisu from parent Jun 13, 2023
@cstamas cstamas merged commit f251212 into master Jun 13, 2023
@cstamas cstamas deleted the change-guice-to-proper branch June 13, 2023 17:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cstamas