Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SUREFIRE-2153 + SUREFIRE-2160 #625

Merged
merged 2 commits into from
May 4, 2023
Merged

SUREFIRE-2153 + SUREFIRE-2160 #625

merged 2 commits into from
May 4, 2023

Conversation

michael-o
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o marked this pull request as ready for review April 30, 2023 18:22
@michael-o michael-o marked this pull request as draft April 30, 2023 18:22
@asfgit asfgit force-pushed the use-renderer branch 2 times, most recently from 2e6ad07 to 8c3baaf Compare April 30, 2023 22:40
asfgit pushed a commit that referenced this pull request Apr 30, 2023
asfgit pushed a commit that referenced this pull request May 1, 2023
@michael-o michael-o changed the title first shot SUREFIRE-2153 + SUREFIRE-2160 May 1, 2023
@michael-o michael-o marked this pull request as ready for review May 1, 2023 15:00
@michael-o michael-o requested a review from hboutemy May 1, 2023 15:01
@michael-o
Copy link
Member Author

@hboutemy Long overdue, last people of Doxia 2.0.0 preparation.

@asfgit asfgit force-pushed the use-renderer branch 3 times, most recently from 4b2211c to 2946db8 Compare May 1, 2023 20:47
asfgit pushed a commit that referenced this pull request May 1, 2023
@michael-o
Copy link
Member Author

@hboutemy Now all tests pass. Please have a look.

Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice move to a now classical report approach structure

@asfgit asfgit closed this in 33d30c6 May 4, 2023
@asfgit asfgit merged commit 6718f14 into master May 4, 2023
@michael-o michael-o deleted the use-renderer branch May 4, 2023 07:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants