Copy edits in comments, API doc, and messages #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
requested changes
Jan 5, 2025
| @@ -68,9 +68,9 @@ public enum JavaPathType implements PathType { | |||
| * | |||
| * <ul> | |||
| * <li>If {@link #MODULES} path type is also set, then the dependency can be placed either on the | |||
| * class-path or on the module-path, but only one of those. The choice is up to the plugin, | |||
| * class-path or on the module path, but only one of those. The choice is up to the plugin, | |||
| @@ -54,7 +54,7 @@ public interface Type extends ExtensibleEnum { | |||
| String BOM = "bom"; | |||
|
|
|||
| /** | |||
| * Artifact type name for a JAR file that can be placed either on the class-path or on the module-path. | |||
| * Artifact type name for a JAR file that can be placed either on the class-path or on the module path. | |||
| @@ -124,31 +124,31 @@ private void addPathElement(PathType type, Path path) { | |||
|
|
|||
| /** | |||
| * Adds main and test output directories to the result. This method adds the main output directory | |||
| * to the module-path if it contains a {@code module-info.class}, or to the class-path otherwise. | |||
| * to the module path if it contains a {@code module-info.class}, or to the class-path otherwise. | |||
gnodet
approved these changes
Jan 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular I've followed Oracle's usage of unhyphenated "class path" and "module path" when referring to the concepts instead of the CLI argument. --module-path is still used when referring to the command line flags.