Add interface to configure details of JGit's pack implementation #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaswolf
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Looks good, just some minor details that will make the CI build fail.
Also: run this at least once through the maven build. The maven build enforces our formatting rules by re-formatting. If there are any changes after that, commit them: the CI build will fail if formatting is not clean.
Finally, please squash all these small commits into one.
sshd-git/src/main/java/org/apache/sshd/git/pack/GitPackConfiguration.java
Show resolved
Hide resolved
sshd-git/src/test/java/org/apache/sshd/git/pack/GitPackCommandTest.java
Outdated
Show resolved
Hide resolved
sshd-git/src/main/java/org/apache/sshd/git/pack/GitPackConfiguration.java
Outdated
Show resolved
Hide resolved
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal to close #616 .
I'm open for suggestions for changes to the interface or the naming, but in general I think this would be a very useful thing to have.