Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Revert "Change the way NDArrayIter handle the last batch" #12537

Merged
merged 9 commits into from
Sep 12, 2018

Conversation

zhreshold
Copy link
Member

Reverts #12285

See #12526

Will fix the issue offline.

@zhreshold zhreshold requested a review from szha as a code owner September 12, 2018 18:40
@zhreshold
Copy link
Member Author

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense given the user impact. Thank you.

@vishaalkapoor
Copy link
Contributor

LGTM.

@szha szha merged commit 8ff50c9 into master Sep 12, 2018
@szha szha deleted the revert-12285-change_NDArrayIter_last_batch_handle branch September 12, 2018 20:33
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* Revert "Removing the re-size for validation data, which breaking the validation accuracy of CIFAR training (apache#12362)"

This reverts commit ceabcaa.

* Revert "[MXNET-580] Add SN-GAN example (apache#12419)"

This reverts commit 46a5cee.

* Revert "Remove regression checks for website links (apache#12507)"

This reverts commit 619bc3e.

* Revert "Revert "Fix flaky test: test_mkldnn.test_activation apache#12377 (apache#12418)" (apache#12516)"

This reverts commit 7ea0533.

* Revert "further bump up tolerance for sparse dot (apache#12527)"

This reverts commit 90599e1.

* Revert "Fix broken URLs (apache#12508)"

This reverts commit 3d83c89.

* Revert "Temporarily disable flaky tests (apache#12520)"

This reverts commit 35ca13c.

* Revert "Add support for more req patterns for bilinear sampler backward (apache#12386)"

This reverts commit 4ee866f.

* Revert "Change the way NDArrayIter handle the last batch (apache#12285)"

This reverts commit 597a637.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants