-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-908] Enable python tests in Travis #12550
[MXNET-908] Enable python tests in Travis #12550
Conversation
Thanks for your contribution @KellenSunderland |
The build is failing with the same error users are receiving. It's a valid
failure which we were trying to reproduce in CI. The next steps to resolve the problem are to fix the MacOS issues, then merge this PR.
…On Fri, Sep 14, 2018, 7:48 PM Kalyanee Chendke ***@***.***> wrote:
Thanks for your contribution @KellenSunderland
<https://github.com/KellenSunderland>
I noticed the build is failing
@mxnet-label-bot <https://github.com/mxnet-label-bot>
[pr-awaiting-response]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12550 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHGTE41dXviBdT0iIwUwbaiib_VDvVpKks5ua-v0gaJpZM4WnbJC>
.
|
f883d61
to
4c32fa7
Compare
@KellenSunderland it seems like everything is passing. Is this good to merge? |
It's ok to merge. My preference would be to wait a day and then I'll split
the fix into it's own PR (to make it easy to revert/bisect/cherry pick into
release branches).
…On Mon, Sep 17, 2018, 9:15 AM Marco de Abreu ***@***.***> wrote:
@KellenSunderland <https://github.com/KellenSunderland> it seems like
everything is passing. Is this good to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12550 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHGTEyBTgpAFs9lltPM-0C9Fd87WN0ibks5ub6CJgaJpZM4WnbJC>
.
|
@@ -29,3 +29,4 @@ script: | |||
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0 | |||
- mv make/osx.mk config.mk | |||
- make -j 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KellenSunderland instead of placing python here as a job that travis would always execute, could you please put python build section into a separate target so we can also add Scala-maven test in here in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly this will help: https://docs.travis-ci.com/user/build-stages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be great if we could add Scala tests as well, but I do have a few concerns. How long would they take to execute? Let's keep in mind that we have a limited number of executors that can be run before we begin interfering with other Apache projects. There's also a global timeout of ~45 minutes to build and execute on a virtualized MacOS host which takes a few minutes just to start. I'd ideally like to keep our total test time below 30 minutes to avoid hitting this in the future.
In principle I'm not against build stages, but unless we have a lot of jobs running in parallel that have dependencies on each other I don't see a big benefit in using them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply! If you mean scalaunittest
it will be around 10 mins or less. Is travis wait possible to apply in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately Travis wait won't help in this case. The tests are active and sending output to Travis, they just take a long time and hit the global timeout for Travis jobs.
10 minutes actually is reasonable. Let's do a test run with Scala enabled after this is merged and see if we can get it included. My guess is if we enable folder caching, and cache models we're currently downloading we'll be able to fit it in and not hit the global timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's try to make Scala test available later in Travis.
be94645
to
4d68026
Compare
Note: this will fail in Travis until this PR is merged: #12590 |
This turns on python tests in Travis in order to increase or MacOS coverage.
4d68026
to
4d5df88
Compare
Rebased, should build properly now. |
Looks like we are still suffering the timeout issue: https://travis-ci.org/apache/incubator-mxnet/builds/433814087?utm_source=github_status&utm_medium=notification |
Description
This turns on python tests in Travis in order to increase or MacOS coverage.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.