Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add override_content_disposition for OpRead #1739

Closed
Tracked by #1738
Xuanwo opened this issue Mar 23, 2023 · 4 comments · Fixed by #1742
Closed
Tracked by #1738

Add override_content_disposition for OpRead #1739

Xuanwo opened this issue Mar 23, 2023 · 4 comments · Fixed by #1742

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 23, 2023

  • Add override_content_disposition for OpRead
  • Implement override_content_disposition support in s3
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 23, 2023

Hi, @baszalmstra, would you like to help implement this issue? This can fix #1726.

@baszalmstra
Copy link
Contributor

baszalmstra commented Mar 23, 2023

Should I also implement other override flags? These are the ones supported by S3:

  • response-content-type
  • response-content-language
  • response-expires
  • response-cache-control
  • response-content-disposition
  • response-content-encoding

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 23, 2023

Should I also implement other override flags? These are the ones supported by S3:

I prefer to add response-content-disposition first.

@baszalmstra
Copy link
Contributor

See: #1742

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants