Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add override_content_disposition support for azblob #1979

Closed
Xuanwo opened this issue Apr 14, 2023 · 4 comments · Fixed by #2065
Closed

Add override_content_disposition support for azblob #1979

Xuanwo opened this issue Apr 14, 2023 · 4 comments · Fixed by #2065
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/azblob

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2023

Take #1739 for reference.

@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed services/azblob labels Apr 14, 2023
@Essoz
Copy link
Contributor

Essoz commented Apr 21, 2023

Hi @Xuanwo, I can help with this if there aren't anyone working on this.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 21, 2023

Thanks a lot! Have fun!

@Essoz
Copy link
Contributor

Essoz commented Apr 22, 2023

Hi, I am wondering if there are any methods to test my code without relying on GitHub actions? These actions are only run when I create a pull request, but I don't want to push corrupt code before creating PRs.

PS: I tried to run cargo test on my development machine (an Apple Silicon MacBook), but seems to me that a lot of symbols required to build the codebase were missing on Arm64. One thing I can do is to do my development in containers.

Update: Ok I just took a look at the GitHub Actions manifests and understood how to run tests.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 22, 2023

PS: I tried to run cargo test on my development machine (an Apple Silicon MacBook), but seems to me that a lot of symbols required to build the codebase were missing on Arm64. One thing I can do is to do my development in containers.

cargo test on the top level requires to build all bindings, please try running inside core. And we can use cargo test azblob to only running azblob related tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/azblob
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants